Catching exceptions on empty results
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 377
- Forks
- 280
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 10
Description
Hi @M0un,
I just merged the pull request containing your new module and did a few tests on it.
There is one issue I saw with the loop on search results, since you are iterating on the indexes, when the results are empty search_results[i] will raise an IndexError.
It would be great if you could fix it.
Do not hesitate to keep in touch with @Rafiot or me if you have any question
(Also sorry I already fixed some indentation issues, so you will have to pull the origin into your fork 👼)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the newly merged module's loop that indexes search_results, then reproduce the case where the results are empty. The work is done when empty results no longer raise IndexError; contact the maintainers if the module location or expected behavior is unclear.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100