MISP / MISP/misp-docker

ADMIN_KEY envar expires and recreates matching keys on startup without preserving allow lists

Open
#443 1 comment 0 reactions 1 assignee View on GitHub

@jeremiah-RENISAC is already working on this.

Since Sep 10, 2026.

bug
Dominant language
Shell
Stars
394
Forks
194
Avg merge
3d 9h
Merged PRs (30d)
9

Description

If the ADMIN_KEY envar is set, the following code block in configure_misp will run on every container start and potentially expire then recreate matching keys without preserving any allowlist entries set for the admin key.

    if [ -n "$ADMIN_KEY" ]; then
        if [ "$DISABLE_PRINTING_PLAINTEXT_CREDENTIALS" == "true" ]; then
            echo "... setting admin key from environment variable"
        else
            echo "... setting admin key to '${ADMIN_KEY}'"
        fi
        CHANGE_CMD=(sudo -u www-data /var/www/MISP/app/Console/cake User change_authkey 1 "${ADMIN_KEY}")

This should be updated to check if the user 1 key is already set to ADMIN_KEY, and if so, take no action to prevent creating duplicate entries or removing IP allow lists.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.