Advanced authkeys tests
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 491
- Forks
- 290
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 3
Description
- By default MISP now installs with advanced auth keys
- Retrieving of keys is no longer possible from user objects
-- temporarily removed the test for the authkey being correct
For future improvements:
- restore the authkey test
-- for advanced authkeys we can still check the list of assoiated authkeys and compare the first/last 4 characters which are stored in the clear - build a new test for the creation of new API keys
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the temporarily removed authkey correctness test and the existing tests for user objects and API key creation. Restore verification using the stored first and last four characters for advanced authkeys, then add coverage for creating new API keys; done means both behaviors are tested without retrieving the full key from user objects.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, authentication, testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100