rotation and RTI do not respect no_mix from mlt.
- Dominant language
- Fortran
- Stars
- 249
- Forks
- 82
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 3
Description
Tagging people for a second opinion.
I have noticied: when mlt sets a zone to radiative, the diffusive mixing coefficient from mlt is set to 0, which prevents mixing. This is fine, but it is not clear how this should behave with rotation. Should the rotational mixing coefficient also be set to 0?
This can be problematic when controls like `max_abs_du_div_cs_for_convection` are used to limit convection over shocks. While convection across the shock is prohibited, rotation and potentially RTI can still mix zones across the shock interface, which can result in all sorts of issues.
see:
https://github.com/MESAHub/mesa/blob/735d8fe51e171de82d70d5b314965451fcc324f1/star/private/turb_info.f90#L291-L332
What does this affect? : Mainly rotating ppisn or cc models or really any model that is rotating and also has a shock interface.
What is the solution? : We need some check in `mix_info.f90` that sets the diffusion coefficient to 0 when `max_abs_du_div_cs_for_convection`.
Perhaps somewhere inside https://github.com/MESAHub/mesa/blob/735d8fe51e171de82d70d5b314965451fcc324f1/star/private/mix_info.f90#L48
Contributor guide
Assessment
This issue has not been assessed yet.