Remove_shells functionality needs TDC support
- Dominant language
- Fortran
- Stars
- 249
- Forks
- 82
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 3
Description
Remove_shells functionality for `star_relax_to_cut` is missing support for TDC. I label this as affecting the test_suite because this subroutine is called inside `ppisn` see below:
https://github.com/MESAHub/mesa/blob/d4aeadacf5567884f25ed4a892bb67f841a8af4c/star/private/remove_shells.f90#L1154-L1157
https://github.com/MESAHub/mesa/blob/d4aeadacf5567884f25ed4a892bb67f841a8af4c/star/private/remove_shells.f90#L1224-L1241
https://github.com/MESAHub/mesa/blob/d4aeadacf5567884f25ed4a892bb67f841a8af4c/star/private/remove_shells.f90#L1353-L1371
Contributor guide
Research direction
Start in star/private/remove_shells.f90 at the referenced lines around star_relax_to_cut and trace its call from ppisn. Compare the existing remove_shells behavior with the expected TDC path, then validate the change through the relevant test_suite coverage. Done means star_relax_to_cut supports TDC without regressing the existing shell-removal behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100