MESAHub / MESAHub/mesa

reading star_job_controls from rse doesn't toggle v_flag

Open
#777 0 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
Fortran
Stars
249
Forks
82
Avg merge
1d 3h
Merged PRs (30d)
3

Description

When using `call read_star_job(s, "inlist_turn_on_v_flag", ierr)`, where `inlist_turn_on_v_flag` contains:

```
&star_job
! see star/defaults/star_job.defaults

change_v_flag = .true.
new_v_flag = .true.

/ ! end of star_job namelist

```

We find that v_flag does not change. Whether or not the subroutine is called from `extras_start_step` or `extras_finish_step` v_flag does not change. All other star_job_controls can be changed, but not v_flag.

Perhaps this is done on purpose, but it appears to be a bug. I have attached a clean tar file to reproduce this bug.

[test_rse_v_flag.tar.gz](https://github.com/user-attachments/files/18711312/test_rse_v_flag.tar.gz)

Contributor guide

Open the contributing guide

Research direction

Start with the attached test_rse_v_flag.tar.gz and the read_star_job call in the issue, then compare how v_flag is handled with the other star_job_controls that do change. Reproduce the behavior from the clean test case and trace the star_job namelist processing. Done means change_v_flag and new_v_flag take effect when read_star_job is called from either extras_start_step or extras_finish_step.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
hpc
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.