Generalize composition diffusivity used for thermohaline calculations
Open
@evbauer is already working on this.
Since Nov 10, 2023.
enhancement
- Dominant language
- Fortran
- Stars
- 249
- Forks
- 82
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 3
Description
When the composition diffusivity enters into thermohaline calculations (e.g. when thermohaline_option = Brown_Garaud_Stellmach_13), currently we assume a H/He-dominated mixture. See
https://github.com/MESAHub/mesa/blob/d215b38166687af0351c621f47ddf622415625d7/turb/private/thermohaline.f90#L128-L153
We already have all of the physics in the code to do the more general case elsewhere for element diffusion, so we should take advantage of that here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.