MESAHub / MESAHub/mesa

Inability to get through helium flash for 1.05 - 1.4 Msolar

Open
#563 1 comment 0 reactions 1 assignee Claimed by @pmocz View on GitHub
documentation enhancement test_suite
Dominant language
Fortran
Stars
249
Forks
82
Avg merge
1d 3h
Merged PRs (30d)
3

Description

MESA version 23051

Comparing this inlist (attached as .txt) for a science case against `inlist_1.3M_ms_high_Z` from the `test_suite` case of the same name, I have systematically removed each difference in physics (replace with `basic.net`, use standard opacities, etc) to try to isolate the reason the science inlist fails. I have not found any change that enables successful passage through the helium flash
[inlist_issue.txt](https://github.com/MESAHub/mesa/files/12129491/inlist_issue.txt)

However, introduction of the following control parameters _does_ enable passage through the he flash:
` convergence_ignore_equL_residuals = .true.
relax_use_gold_tolerances = .true.
`

Despite confirmation from other devs that this control is needed to get models in this regime through the he flash (as of some point after release 10398 and the solver controls overhaul),
there is no documentation to accompany ` convergence_ignore_equL_residuals = .true.`

I think a few things need to happen:
1. the effect of this and similar controls needs to be documented. As far as I can tell, the meaning of this control is to shut off consideration of discrepancies in the luminosity equation entirely (?).
a. Corollary: is that safe??

2. It needs to be made loud and clear that this setting is necessary for (most) AGB models. I advocate for introducing it in `inlist_1.3M_ms_high_Z` even though it is _not_ required in that case, just so users are aware of it. They will almost certainly consult this `test_suite` case when trying to figure out their own convergence issues for AGBs. It has been pointed out to me that this setting is in the `1M_pre_ms_to_wd` `test_suite` case, but that is not the first place I personally would look for usable AGB settings.

3. We need a test case for AGBs (@giulia-cinquegrana and I are doing this, stand by)

4. Ideally, we need a better solution than (even a well-documented) magic flag for dealing with this. If the era of tighter tolerances made getting through the he flash impossible without telling the solver to ignore one of the stellar structure equations(?)...that seems like something we should fix.

end rant!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.