Switch donor function does not support 'Kolb' scheme
Open
@matthiasfabry is already working on this.
Since Jun 2, 2023.
binary
- Dominant language
- Fortran
- Stars
- 249
- Forks
- 82
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 3
Description
**Describe the bug**
In the 'Kolb' scheme, the switching of the donor star does not occur when the accretor fills the Roche lobe initiating a reverse mass transfer. The accretor can expand arbitrarily..
**To Reproduce**
Evolve two stars with close masses q~0.95 and proper period.
Use 'Kolb' scheme
**Expected behavior**
subroutine **set_donor_star** is able to correctly identify the donor regardless of the mdot scheme being used.
**Relevant code**
In binary_evolve.f90, subroutine **set_donor_star**:
224 `if (b% mdot_scheme == "roche_lobe" .and. &`
239 `else if (b% mdot_scheme == "contact" .and. &`
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.