Inconsistency between 15140 and 23.05.1-rc2: emergence of pre TP-AGB oscillatory feature
- Dominant language
- Fortran
- Stars
- 249
- Forks
- 82
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 3
Description
Discovered with @mjoyceGR, following the issue #537 raised by @mjoyceGR during attempts to replicate results from TP-AGB inlists used with version 15140 with version 23.05.1
Using supposedly identical physics, we see the emergence of a pulsation feature prior to the TP-AGB when using version 23.05.1. This feature is not present when using 15140 (see three figures attached).
We attach also two sets of inlists: one pair from 15140 and one pair or 23.05.1, inlist_common is identical in both.
The changes in inlist_TP_AGB are:
(1) to the H limit controls discussed in issue #537
(2) the need to comment out the following controls, present in 15140,
```
dH_div_H_limit_min_H = 1d-5
dH_div_H_limit = 0.5
```
for the 23.05.01 model to run.
@evbauer suggested looking into TDC, we do not think this is likely the issue given that Henyey MLT was explicitly defined in the new version of the inlists. Any thoughts as to what has caused this change? Has there been significant adjustment to how resolution controls are handled since 15140?



[inlists.zip](https://github.com/MESAHub/mesa/files/11623497/inlists.zip)
Contributor guide
Research direction
Start with the attached inlists.zip, comparing the 15140 and 23.05.1-rc2 pairs, especially inlist_common and inlist_TP_AGB. Reproduce the pre-TP-AGB oscillatory feature and investigate the H limit controls, resolution controls, and explicitly configured Henyey MLT; done means identifying the cause of the version difference.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- hpc
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100