ME-ICA / ME-ICA/godec

Wavelet transform adds columns to resulting array

Open
#4 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
2
Forks
0
PR merge metrics
No merged PRs in 30d

Description

In the test dataset, there are 239 volumes. After apply the wavelet transform and then the inverse transform, there are 240, even when nothing's been done to the data.

Weirdly, np.allclose between the original data and the first 239 volumes of the transformed data passes.

It seems like the extra column is added when the number of columns in the raw data is >200. Fortunately, based on https://github.com/PyWavelets/pywt/issues/564#issuecomment-675515586, it seems like that final column can just be trimmed out!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the wavelet transform and inverse-transform entry points used with the test dataset. Reproduce the case with 239 volumes and compare the original data with the first 239 output volumes, as described in the issue. Done means the round trip does not retain an unintended 240th volume while preserving the existing values.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.