ME-ICA / ME-ICA/aroma

Accept arrays in feature functions

Open
#7 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Effort: Medium Enhancement Impact: High Priority: Medium Tests
Dominant language
Python
Stars
7
Forks
11
PR merge metrics
No merged PRs in 30d

Description

Summary

To reduce the number of temporary files we may need to write, we should allow the feature functions to accept arrays in addition to files.

Additional Detail
Next Steps
  1. Check datatypes of inputs to feature functions. If str, load the file. If array, use that directly.
  2. Update the docstrings.
  3. Add tests for both types of inputs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the feature functions and inspect how they currently load file inputs. Update their docstrings and add tests covering both file paths and arrays; done means both input types are accepted without unnecessary temporary files.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.