Log Spam When Shaderpacks Failed To Load
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.2k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
After 4c41a166a02fb43a066430489fb2ec73fc36c1c1, when shaderpack failed to load (typically because of a syntax error, which is common in shader dev/debugging), the log will be flooded with "Viewport width or height was zero, this is bad bad bad, exiting frame", which both increases log file size and make it hard to find the actual shader compile error message (though you can see it ingame if you activate iris's debug mode).
It seems that the message is printed every frame.
Example log: https://mclo.gs/iDdQUEz
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the codebase for the exact message "Viewport width or height was zero" and inspect the per-frame path introduced after commit 4c41a166a02fb43a066430489fb2ec73fc36c1c1. Reproduce a shaderpack syntax-error failure and verify that the viewport warning is no longer flooded every frame while the shader compile error remains visible.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- computer-graphics, game-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100