MCG-NJU / MCG-NJU/NeuralSolver
[Question] Possible redundant Euler step in sampling loop ddpm/neuralsolver.py
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 21
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
First of all, I really enjoyed and found the paper very interesting — thanks for sharing this work!
While reading the code, I noticed what seems to be an extra Euler-like update in the sampling loop:
pred_trajectory.append(x0)
delta_lamda = lamda_next - lamda
x = (sigma_next/sigma) * x + sigma_next * (delta_lamda) * x0
This runs after the main coefficient-weighted update, so it might be redundant and could overwrite the intended solver step.
Is this behavior correct, or should the extra update be removed?
Thanks in advance! :)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in ddpm/neuralsolver.py and inspect the sampling loop around pred_trajectory.append(x0), delta_lamda, and the subsequent x update. Compare that update with the preceding coefficient-weighted solver step and the intended sampling behavior described in the paper. Done means determining whether the extra Euler-like update is intentional or redundant and documenting the conclusion or removing it if confirmed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100