M-Agoumi / M-Agoumi/Simfa

already existing folder takes over the routes [see details]

Open
#10 0 comments 0 reactions 1 assignee View on GitHub

@M-Agoumi is already working on this.

Since Jul 30, 2022.

bug good first issue
Dominant language
PHP
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

current rewrite mod only rewrites not existing files, let's assume our public folder structure like the next

- **public**
- **pictures**
- _myImage.jpg_
- _background.png_
- _index.php_

now let's create a route in **routes/web.php**:
`\Simfa\Framework\Router::get('pictures', function(){ return 'hello world';}`
when we visit **_https://example.com/pictures_** instead of getting the request handled by our application it gets handled by Apache either indexing the folder or showing access denied

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.