LuxCoreRender / LuxCoreRender/BlendLuxCore
Rework unit scale handling
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 877
- Forks
- 108
- PR merge metrics
- No merged PRs in 30d
Description
We scale all objects in the scene by the scene scale (like it was done in LuxBlend).
I think the point of the scene scale is to get rid of precision issues with very small/large objects, not to create new issues.
We should change our approach: do not scale all the objects in the scene, but instead scale all other parameters that depend on scene scale (volume absorption depth, camera fstop etc.).
This would solve the following issue:
https://github.com/LuxCoreRender/BlendLuxCore/issues/77
edit: the "photographer" addon contains code to convert the F-Stop according to unit scale.
https://gumroad.com/l/FWQf
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source files or tests are named. Start by tracing the scene-scale handling and review linked issue #77, then identify every scale-dependent parameter, including volume absorption depth and camera F-stop. Done means objects are no longer globally scaled and those dependent parameters behave correctly across scene scales.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- blender, python
- Domain
- computer-graphics
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100