Lusito / Lusito/web-ext-translator

Group issues with AMO/wen-ext lint and web-ext build

Open
#23 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
52
Forks
9
PR merge metrics
No merged PRs in 30d

Description

It seems, that AMO/web-ext lint complain about duplicate keys in the messages.json, so currently it's not possible to use plain WET_GROUP as key. A suffix needs to be appended.

Also an issue: Comments in the messages.json files are allowed by AMO/web-ext lint, but web-ext build complains about not being able to parse the json files.

I'll try to convince Mozilla to fix both of these, but in case this won't get fixed, I'll have to change a couple of things.

See:

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the messages.json files and reproducing the duplicate-key and comment-parsing behavior with AMO/web-ext lint and web-ext build. Read the linked web-ext issues to determine whether the external behavior has changed; done means the translator's generated messages.json files work with both checks, if a project-side change is still needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system, localization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.