LukePrior / LukePrior/nbn-upgrade-map

Don't reload the suburb history when changing dates

Open
#321 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
222
Forks
28
Avg merge
1m
Merged PRs (30d)
2

Description

The list of changes to the suburb file (history) doesn't change when you select a different one, so it should be cached rather than refetched from the website. After https://github.com/LukePrior/nbn-upgrade-map/issues/309 in fact it shouldn't be fetched, even if suburb is changed (since the result contains gitlogs for all suburbs)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read issue #309 first, then trace the entry point that fetches the suburb-file history when the selected date or suburb changes. Verify how the history data is requested and cached; done means the existing all-suburb git history is fetched only when needed, not refetched for date or suburb changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
frontend, performance
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.