LukeMathWalker / LukeMathWalker/zero-to-production
HmacSecret app_data not actually used
Open
- Dominant language
- Rust
- Stars
- 6.5k
- Forks
- 585
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/LukeMathWalker/zero-to-production/blob/236cef05a5f4bbdeb2e10103bee5c739795befeb/src/startup.rs#L110
^^ AFAICT, by about 3/4 through Chapter 10, HmacSecret is not used in any way and that app_data line is irrelevant.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at src/startup.rs around line 110 and trace HmacSecret through the Chapter 10 code to confirm whether it is ever read after being registered with app_data. Done means resolving the unused registration consistently with the chapter’s intended application state, then checking the relevant startup flow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 40/100