LukeMathWalker / LukeMathWalker/wiremock-rs

Implicit use of `tokio::net`

Open
#141 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
799
Forks
91
PR merge metrics
No merged PRs in 30d

Description

Seems that the features is enabled by hyper_util but it's not enabled on this crate even though it's being used.

I was exploring the option to make wiremock wasm-unknown-unknown happy but sadly hyper_util doesn't allow it because it relies on tokio `net` which relies on `mio`. And mio only supports the `wasm-wasi` (there are OS socket after all)

While `socket2` is not actually mandatory for the tokio feature itself but clien-legacy in hyper_util.

PS: Would be nice to enable `resolver = "2"` as well.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by checking the crate's dependency feature declarations and hyper_util's tokio and socket2 requirements for wasm-unknown-unknown. Verify whether enabling tokio net and resolver 2 is appropriate, then confirm that dependency resolution and target compatibility match the issue's goal.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.