LukeMathWalker / LukeMathWalker/bunyan

Tests rely on deprecated `assert_cmd::cargo_bin` which will break on future Cargo versions

Open
#23 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
114
Forks
15
PR merge metrics
No merged PRs in 30d

Description

https://github.com/LukeMathWalker/bunyan/blob/e3362cb045e207f8333eb7cd4c725a78566da331/tests/all/helpers.rs#L5

cargo_bin relies on implementation details of cargo that will soon break (rust-lang/cargo#16147, rust-lang/cargo#15010).

You can test this by running:

CARGO_BUILD_BUILD_DIR="{cargo-cache-home}/build/{workspace-path-hash}" cargo test

The replacement is assert_cmd::cargo_bin!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in tests/all/helpers.rs at the linked line and review how the deprecated assert_cmd::cargo_bin usage is called. Run cargo test with the CARGO_BUILD_BUILD_DIR setting from the issue, replace the usage with assert_cmd::cargo_bin!, and confirm the tests pass under that configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
testing
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.