LuisMayo / LuisMayo/objection_engine
Correct certain punctuation spacing
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 122
- Forks
- 24
- PR merge metrics
- No merged PRs in 30d
Description
I found out that in some cases the bot breaks up some punctuation symbols in a message's text like if they were another word. I believe this happens because of the tokenization process.
I tried some examples to test this in this order: Original message's text -> Text processed by the bot (what appears in the video)
```
"The command !render is very good!" -> "The command ! render is very good!"
"Don't be mean! :c" -> "Don't be mean! : c"
"?info @Member" -> "? info @Member"
"Exactly what i said :v" -> "Exactly what i said : v"
```
This seems to happen in specific situations such as a bot command that uses a punctuation, or some 'emojis' like a face made using a colon and a letter. If it could be changed so it doesn't add a space in these cases it would be very nice.
Also, i have another suggestion. Make the text of a character's dialogue have the same markdown as the message's text in Discord. For example, if a member said something in bold (using '**'), instead of showing the raw text, the appropriate part of the text could be in bold. The same with italics and strikethrough, but not with spoiler, code or cite, as these are too specific.
I'm not sure if there's a limitation with the font to do this, but if it is possible, i believe it should be done, it will even save space for the dialogue.
If you want to be more accurate to the original game's dialogue, maybe orange text for bold and blue for italics (leaving out the strikethrough, a color wouldn't be appropriate).
What do you think?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the listed punctuation examples and tracing the tokenization process used for bot commands and dialogue text. Check how dialogue text is rendered in Discord scenes, then determine whether the requested bold, italic, and strikethrough formatting belongs in the same change. Done means punctuation spacing is preserved and the supported markdown formatting is rendered without affecting excluded formats.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100