LuisMayo / LuisMayo/objection_engine

Graphical suggestions

Open
#22 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
122
Forks
24
PR merge metrics
No merged PRs in 30d

Description

I have a few graphical suggestions to make the video generated bots more accurate to the in-game images. The first one is the nameplates font:
![image](https://user-images.githubusercontent.com/60068235/109789804-fc59da00-7c10-11eb-87b2-e325b03bfbaf.png)
This is how the bot generates the video,
![image](https://user-images.githubusercontent.com/60068235/109789956-26ab9780-7c11-11eb-9412-a5af7c3d15f7.png)
and this is an actual in-game screenshot (notice the different font), there's a recreation of that font (since those nameplates are images in the game's files and not actual text) which can be found [here](https://fontstruct.com/fontstructions/show/1799842/ace-name).

The other suggestion would be to use the European font (used in the French, German, Spanish and Italian localizations) if the bot detects the language is not English,
![image](https://user-images.githubusercontent.com/60068235/109790925-2d86da00-7c12-11eb-9f2a-3e8f0fdeacec.png)
This is an image from the bot's font using the American version font,
![image](https://user-images.githubusercontent.com/60068235/109791124-64f58680-7c12-11eb-8a1d-197636c4ed7c.png)
and this is an image of the European font (look how even if both are pixel fonts, they're still pretty different. Check the letters a, e, s or g). There used to be a conversion to ttf for this font in Fontstruct, but I believe it got deleted. I downloaded it time ago so I can reupload it somewhere else.
EDIT: It looks like it wasn't deleted, [here it is](http://origin.fontstruct.com/fontstructions/show/553660/ace_attorney_eu).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked screenshots and font references to understand the requested nameplate and localization differences. Then locate the rendering and language-selection entry points; the work is done when English uses the requested nameplate font and French, German, Spanish, and Italian use the European font.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
design
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.