LuaLS / LuaLS/vscode-lua

Known addons can update without making PR

Open
#162 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

addon manager
Dominant language
TypeScript
Stars
215
Forks
62
PR merge metrics
No merged PRs in 30d

Description

Hi there, hope you are all well!

The Garry's Mod addon was last updated through a PR at LLS-Addons on October 3rd 2024. That was version v0002. Since then some new versions have been published to our library repo, however at the time of writing I have yet to make a PR to merge them into LLS-Addons.

Despite not having had a PR (and thus no manual validation by @carsakiller) the newer versions show up and can be switched to:

afbeelding

I remember reading somewhere that the manual process of updating an addon through PR is a sort of security/sanity check. For that reason I don't believe this is intentional

Note that selecting the 'latest' version will still result in the LLS-Addons version to be chosen (for gmod: v0002)

Details

  • Using VSCode Extension 3.13.5
  • Windows 10
  • git version 2.44.0.windows.1
  • Webvue version v0.2.0
[2025-01-11 12:03:47] |  VERBOSE  |       Command      | Executing "setVersion" ({"command":"setVersion","data":{"name":"garrysmod","version":"v0006"}})

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the setVersion command with the Garry's Mod addon and trace how addon versions are discovered and selected in the VSCode extension. Check why releases newer than the LLS-Addons version become selectable without a pull request. Done means unmerged versions cannot be selected, while latest still resolves to the validated v0002 version.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.