LuaLS / LuaLS/lua-language-server

Generic Class: a method does not catch the type

Open
#3,433 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
4.4k
Forks
442
PR merge metrics
No merged PRs in 30d

Description

---@class Map<T>
Map = {}

---@param key T
---@return any?
function Map:Find(key) end

---@param key T
---@return boolean
function Map:Contains(key) end

---@param key T
function Map:Erase(key) end

function Map:Clear() end


---@class NumberMap: Map<number>
NumberMap = {}

---@return NumberMap
function NumberMap() end
local map = NumberMap()
map:Find(1)
Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the diagnostic with the generic Map, NumberMap: Map, and map:Find(1) declarations shown in the issue. Start by tracing the Lua language server's generic-class type propagation and inspect how Map:Find resolves its key parameter. Done means the NumberMap specialization is applied when checking Find calls and the resulting diagnostic matches the concrete key type.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.