LuaLS / LuaLS/lua-language-server

can not complete param for "overload" functions

Open
#3,206 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
4.4k
Forks
442
PR merge metrics
No merged PRs in 30d

Description

How are you using the lua-language-server?

NeoVim

Which OS are you using?

MacOS

What is the issue affecting?

Completion

Expected Behaviour

complete param for all overload functions

Actual Behaviour

can only complete params whose param count exactly matches

Reproduction steps
  1. create a lib.lua

    ---@meta test_lib
    
    ---@param p0 string|'aa'|'bb'
    function test(p0) end
    ---@param p0 string|'cc'|'dd'
    ---@param p1 number
    function test(p0, p1) end
    
  2. create a test.lua (| is the cursor position)

    test(|)
    
  3. input ' (single quote) to complete, and only the first function's p0 can be completed

    Image

  4. if the input is test(|, 0), then the second function's p0 can be completed

    Image

Additional Notes

No response

Log File

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the completion behavior with the lib.lua and test.lua examples in the issue, starting from the overload definitions and the call-site completion scenario. Investigate the completion path for overloaded functions and verify that parameter suggestions from all matching overloads appear when the argument list is incomplete.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.