LuaLS / LuaLS/lua-language-server

`luamake test` doesn't find packages

Open
#2,855 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
4.4k
Forks
442
PR merge metrics
No merged PRs in 30d

Description

How are you using the lua-language-server?

Command Line

Which OS are you using?

MacOS

What is the issue affecting?

Other

Expected Behaviour

luamake test runs the same tests with the same results as luamake rebuild

Actual Behaviour

luamake rebuild works.

luamake test can't find packages:

module 'log' not found:
        no field package.preload['log']
        no file 'log.lua'
        no file 'log/init.lua'
        no file './test/log.lua'
        no file './test/log/init.lua'
        no file 'log.so'
        no file 'build/bin/log.so'
stack traceback:
        /Users/sparr/src/lua-language-server/test.lua:20: in main chunk

Updating package.path to point to the log module leads to another failed package load, then multiple additions to package.path to find more modules, eventually leading to needing to compile lpeglabel.so manually, then a dead end when I couldn't figure out how to resolve this one (note the new paths being searched from all the additions I made to package.path to get this far)

module 'luamake' not found:
        no field package.preload['luamake']
        no file 'luamake.lua'
        no file 'luamake/init.lua'
        no file './test/luamake.lua'
        no file './test/luamake/init.lua'
        no file './script/luamake.lua'
        no file './script/luamake/init.lua'
        no file './test/plugins/ffi/luamake.lua'
        no file './make/luamake.lua'
        no file 'luamake.so'
        no file 'build/bin/luamake.so'
stack traceback:
        ...rs/clarence/src/lua-language-server/make/code_format.lua:1: in main chunk
        ...e/src/lua-language-server/script/provider/formatting.lua:1: in main chunk
        ...e/src/lua-language-server/script/provider/capability.lua:8: in main chunk
        ...nce/src/lua-language-server/script/provider/provider.lua:2: in main chunk
        /Users/clarence/src/lua-language-server/script/lclient.lua:11: in main chunk
        /Users/clarence/src/lua-language-server/test.lua:82: in local 'main'
        /Users/clarence/src/lua-language-server/test.lua:119: in main chunk
Reproduction steps
  1. Run 3rd/luamake/luamake rebuild
  2. Run 3rd/luamake/luamake test
Additional Notes

No response

Log File

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the reported commands, 3rd/luamake/luamake rebuild and 3rd/luamake/luamake test, and compare their package paths. Read test.lua, then follow the failing imports through make/code_format.lua and the referenced script files. Done means luamake test finds its packages and runs the same tests with the same results as luamake rebuild.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
build-system, cli, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.