LuaLS / LuaLS/lua-language-server
love.window.getDesktopDimensions wrong return types
Open
Nobody has claimed this yet.
upstream
- Dominant language
- Lua
- Stars
- 4.4k
- Forks
- 442
- PR merge metrics
- No merged PRs in 30d
Description
[Wiki](https://love2d.org/wiki/love.window.getDesktopDimensions) says it should return numbers, in LLS it returns strings: https://github.com/LuaLS/lua-language-server/blob/be5b77b7956970647d4d12d0e83ccf9bb410565b/meta/3rd/love2d/library/love/window.lua#L59-L60
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect meta/3rd/love2d/library/love/window.lua at lines 59-60 and compare its declarations with the linked love.window.getDesktopDimensions documentation. Correct the return types to match the documented numeric values, then verify the metadata no longer reports strings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100