LuaLS / LuaLS/lua-language-server

does not warn when insert an element with a wrong type into a string array

Open
#2,095 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement feat/type check
Dominant language
Lua
Stars
4.4k
Forks
442
PR merge metrics
No merged PRs in 30d

Description

### How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

### Which OS are you using?

Windows

### What is the issue affecting?

Diagnostics/Syntax Checking

### Expected Behaviour

the code:

``` lua
---@type string[]
local test = {}
table.insert(test, 123) -- should warn me when i try to insert an element with a wrong type
```

### Actual Behaviour

does not warn
![image](https://user-images.githubusercontent.com/1661871/236224867-152e2081-4b94-4ca1-8dbe-93d9ccc92d46.png)

### Reproduction steps

1. goto vscode
2. install the latest version of the plugin
3. new a lua file with the code below

``` lua
---@type string[]
local test = {}
table.insert(test, 123) -- should warn me when i try to insert an element with a wrong type
```

4. there is no warnings

### Additional Notes

_No response_

### Log File

_No response_

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the diagnostic issue in a Lua file using the shown table.insert example in the Visual Studio Code extension. Trace the table.insert type-checking entry point and verify that inserting 123 into a string[] produces a warning, then rerun the same reproduction to confirm the diagnostic.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.