LuaLS / LuaLS/lua-language-server

Missing diagnostic for `__call` metamethod arguments

Open
#1,880 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
4.4k
Forks
442
PR merge metrics
No merged PRs in 30d

Description

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

Windows

What is the issue affecting?

Annotations, Type Checking, Diagnostics/Syntax Checking

Expected Behaviour

Attempting to invoke a __call metamethod using parameters inconsistent with type annotations should emit a warning.

Actual Behaviour

No warning is generated.

Reproduction steps

Sample code:

---@class MyClass
---@operator call(string, number):MyClass
local MyClass = {};

MyClass(50, false); -- this should emit some kind of warning
Additional Notes

Thank you for all the good work so far, this extension is invaluable 🥰

Log File

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the LuaLS type-checking and diagnostics handling for the ---@operator call(string, number):MyClass annotation and the MyClass(50, false) reproduction. Done means the inconsistent arguments produce a warning while calls matching the annotation remain valid.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.