LuaLS / LuaLS/lua-language-server

Required modules' returns' types are wrong when more than a single value is returned

Open
#1,868 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
4.4k
Forks
442
PR merge metrics
No merged PRs in 30d

Description

### How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

### Which OS are you using?

Windows WSL

### What is the issue affecting?

Type Checking, Diagnostics/Syntax Checking, Libraries

### Expected Behaviour

First type should be a number, second - a string, third - a boolean

### Actual Behaviour

![изображение](https://user-images.githubusercontent.com/21024632/216047756-87647cd4-2955-4c70-b019-9b7b47d6d0af.png)

### Reproduction steps

main.lua
```lua
local number, string, boolean = require "required"
```
required.lua
```lua
return 1337, "string", true
```

### Additional Notes

_No response_

### Log File

_No response_

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the report with main.lua requiring required.lua, where the module returns 1337, "string", and true. Trace the require return-type handling in the language server and verify that the three assigned variables are inferred as number, string, and boolean with correct diagnostics.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.