LuaLS / LuaLS/lua-language-server

The overload of arguments in the function has ceased to be correctly determined

Open
#1,735 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
4.4k
Forks
442
PR merge metrics
No merged PRs in 30d

Description

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

Windows

What is the issue affecting?

Annotations, Type Checking, Hover, Other

Expected Behaviour

image

Actual Behaviour

image

Reproduction steps
---@enum Enum
local Enum =
{
    ENUM_1 = 1,
    ENUM_2 = 2
}

---@class Test
Test = {};

---@param id integer
---@return Test
function Test:New(id)
    return setmetatable({}, { __index = self });
end

---@param enumId Enum
---@return Test
function Test:New(enumId)
    return setmetatable({}, { __index = self });
end

local test = Test:New(Enum.ENUM_1);
Additional Notes

No response

Log File

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the supplied Lua reproduction in the Visual Studio Code extension and inspect the annotations, type checking, and hover results for the two Test:New overloads. Compare the result with the expected and actual screenshots; done means the call with Enum.ENUM_1 selects the enum overload correctly without losing the integer overload.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua, vscode
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.