LoginRadius / LoginRadius/node-js-sdk
Support for Webpack
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 9
- Forks
- 24
- PR merge metrics
- No merged PRs in 30d
Description
Does this SDK support being bundled with webpack?
Several lines like
```
config.HELPER_PATH = path.join(__dirname, 'helper.js');
var helper = require(config.HELPER_PATH);
```
generate errors: `Critical dependency: the request of a dependency is an expression`
Is there a workaround?
Would you accept a PR fixing this?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the webpack build with the SDK and inspect the dynamic require shown in the issue, including config.HELPER_PATH and path.join(__dirname, 'helper.js'). Determine whether the SDK can be bundled and whether a workaround is needed; done means the webpack build no longer reports the critical-dependency error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, webpack
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100