LizardByte / LizardByte/Sunshine
UPnP status codes are interpreted incorrectly with MiniUPnPc 2.2.8+
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 41.3k
- Forks
- 2.1k
- Avg merge
- 23h 47m
- Merged PRs (30d)
- 124
Description
Is there an existing issue for this?
- I have searched the existing issues
Is your issue described in the documentation?
- I have read the documentation
Is your issue present in the latest beta/pre-release?
This issue is present in the latest pre-release
Describe the Bug
MiniUPnPc 2.3.3 returns 3 for a valid but disconnected IGD and 4 for an unknown device.
Sunshine treats 3 as unknown and accepts only 1 and 2.
The router advertises a valid IGD v2 but reports NewConnectionStatus=Disconnected.
Older MiniUPnPc used 2 for disconnected, explaining the regression.
The fix should use UPNP_*_IGD constants and accept connected, private-IP, and disconnected IGDs.
Expected Behavior
No response
Additional Context
No response
Host Operating System
Windows
Operating System Version
11
Architecture
amd64/x86_64
Package
other (fork of this repo)
GPU Type
n/a
GPU Model
4080 super
GPU Driver/Mesa Version
n/a - network issue
Capture Method
None
Apps
Log output
Online logs
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Sunshine's MiniUPnPc IGD status handling and checking the MiniUPnPc 2.3.3 definitions for the UPNP_*_IGD constants. Verify the behavior for connected, private-IP, disconnected, and unknown IGDs, then run the relevant UPnP or networking tests if available. Done means valid disconnected IGDs are accepted without treating unknown devices as valid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 56/100