LivelyKernel / LivelyKernel/lively.next
Property system should be beefed up to enforce more settings (min, max, isFloat,...)
Open
Nobody has claimed this yet.
✨ enhancement
- Dominant language
- JavaScript
- Stars
- 90
- Forks
- 20
- PR merge metrics
- No merged PRs in 30d
Description
We had a property that was defined like this:
_progress: {
isFloat: true,
min: 0,
max: 1
}
The only code that set this property was this._progress = (scrollPosition - this.start) / this.duration;
However, we got e.g., negative values for _progress.
Is this something that is wrong with lively or did we use this feature wrong?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the shown _progress declaration and assignment, then trace how the property system handles min, max, and isFloat. Confirm whether negative values are expected or indicate missing enforcement, and define the behavior that should be covered before changing it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100