LivelyKernel / LivelyKernel/lively.modules
Module state recorder does not allow to (re)define certain globals
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 8
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
E.g. var name = "foo" as a top level variable throws an Error. This is b/c the module.recorder objects actually inherit from the global object, window in the browser. The global (at least in browsers in nodejs it sees to work) has a guard that certain names are not allowed to be redefined. This guard even applies when used in an object inheriting from the global, hence the problem.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the top-level var name = "foo" failure through the module.recorder object in a browser, then compare it with the Node.js behavior described in the issue. Trace how module.recorder inherits from window and determine how to allow these global definitions without breaking existing recorder behavior; done when the reproduction succeeds in the browser.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100