LivelyKernel / LivelyKernel/lively.modules

manual import via doit doesn't work for non-packages

Open
#33 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
8
Forks
1
PR merge metrics
No merged PRs in 30d

Description

When evaluating an import statement such as `import { h } from "virtual-dom";` from a module that is not contained inside a lively package, the import will not resolve the module correctly, i.e. `h` in the example will be undefined.

Config code:

``` json
"systemjs": {
"map": {"virtual-dom": "./node_modules/virtual-dom/dist/virtual-dom.js"},
"meta": {"node_modules/virtual-dom/dist/virtual-dom.js": {"format": "amd"}}
}
```

It seems that the import statement doesn't use the parent module for lookup:
`await System.normalize("virtual-dom")` => `http://localhost:9001/virtual-dom`
vs.
`await System.normalize("virtual-dom", lively.modules.module("lively.morphic/index.js").id)` => `http://localhost:9001/node_modules/lively.morphic/node_modules/virtual-dom/dist/virtual-dom.js`

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the two System.normalize calls and the import from lively.morphic/index.js using the shown SystemJS map and meta configuration. Trace how the parent module is passed during lookup; done when the non-package import resolves the mapped virtual-dom module and h is defined.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.