LiveSplit / LiveSplit/livesplit-core

Feature request: settings map identical?

Open
#830 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
227
Forks
81
Avg merge
22h 45m
Merged PRs (30d)
3

Description

Either provide a function to tell whether two settings maps are identical, or guarantee that the integer handles are equal whenever the maps are identical.

I don't expect this "identical" operation to be used for implementing the `Eq` trait `==` on the auto-splitter side. My intended use case would be to allow a `load_if_changed` function on the auto-splitter side.

For example:
I load the settings map and call it `A`, and then load it again on a future tick and call it `B`.
If the settings map has been unchanged for that time, then either `A` and `B` should be different handle integers but which "identical" returns true for, or they should be guaranteed to be the same handle integer, in which case there would be no need for a special "identical" function.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Start by locating the settings-map and auto-splitter APIs, then determine whether unchanged maps should be recognized by an identical operation or by stable handle integers; done means one of these behaviors is specified and verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend-api-design
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.