LiveSplit / LiveSplit/livesplit-core

Refactor Settings

Open
#800 0 comments 0 reactions 0 assignees View on GitHub
code quality enhancement needs further discussion
Dominant language
Rust
Stars
227
Forks
81
Avg merge
22h 45m
Merged PRs (30d)
3

Description

At the moment the settings are entirely described through the enum variants and their values. However this has become quite annoying because we use different variants for the different kinds of combo boxes we have. It would be much better if we could just dynamically describe a combo box instead. This is not currently possible because the options would need to be part of the value, which means they would also be stored back when changing such a setting, which doesn't make any sense.

We should look into further improvements such as groups and tooltips while doing this refactoring.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the settings enum variants and the code that stores changed values. Clarify how dynamic combo-box options, groups, and tooltips should be represented; done means settings can describe combo boxes without persisting their options and the requested improvements are covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.