LiveSplit / LiveSplit/livesplit-core

Add Tests for getting and setting component settings

Open
#451 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

code quality enhancement suitable for contributions
Dominant language
Rust
Stars
227
Forks
81
Avg merge
22h 45m
Merged PRs (30d)
3

Description

In #449 we accidentally merged too early. The component settings were in an inconsistent order. We can write a test per component that just iterates through all the settings and sets them with the value they already have. That way we have a basic "smoke test" that ensures that at least a basic interaction like that works across the board. That would've caught this.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or existing tests are named. Start by locating the component settings APIs and current component tests, then add a smoke test for each component that iterates through its settings and sets each value to its existing value. Done means the tests cover all components and pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.