LiveSplit / LiveSplit/livesplit-core
Refactor Segment History
Open
Nobody has claimed this yet.
code quality
enhancement
needs further discussion
suitable for contributions
- Dominant language
- Rust
- Stars
- 227
- Forks
- 81
- Avg merge
- 22h 45m
- Merged PRs (30d)
- 3
Description
We use the sign of the segment history attempt IDs to differentiate whether they belong to a real attempt or a generated, algorithmic one. This causes lots of weird issues and is not idiomatic Rust at all. We should refactor this at some point.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file, test, or entry point is named. Start by locating how segment history attempt IDs use their sign to distinguish real and generated attempts, then determine the replacement design and its affected callers; done means that distinction remains reliable without the sign convention.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100