LiveSplit / LiveSplit/livesplit-core

Run Tests with miri

Open
#192 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

ci code quality enhancement priority: low stalled work in progress
Dominant language
Rust
Stars
227
Forks
81
Avg merge
22h 45m
Merged PRs (30d)
3

Description

Run all the suitable tests with miri. Panicking ones and possibly really expensive ones should probably be skipped. Random numbers, such as necessary for Hash Maps are now possible with -Zmiri-seed=123. Accessing time stamps doesn't work with miri either, but fortunately, we already dealt with this problem for wasm-unknown, so miri is just another platform where we mock the time stamps.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing wasm-unknown timestamp mocking and the test configuration used for platform-specific runs. Run suitable tests under Miri with the specified seed, excluding panicking or expensive tests, and verify that timestamp access is mocked successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.