LiveSplit / LiveSplit/SpeedrunComSharp
client.Users.GetPersonalBests throws a serialization exception if you use any of the optional parameters
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 32
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Description
i think it's constructing the URL incorrectly, getting a 404, and then failing to serialize that 404 json into an actual C# object
it looks like the code for UserClient.GetPersonalBests just concatenates the query parameters to the URL string without adding the necessary ? and &s, which doesn't generate a valid URL for the SRC API
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in SpeedrunComSharp/Users/UsersClient.cs at UserClient.GetPersonalBests, linked from the issue, and inspect how optional parameters are appended to the request URL. Verify requests with optional parameters produce valid SRC API URLs and no longer turn a 404 response into a serialization exception.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100