LiveSplit / LiveSplit/LiveSplitOne

"The lock count should never be negative" after Clean Sum of Bests

Open
#1,066 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
301
Forks
55
Avg merge
8m
Merged PRs (30d)
1

Description

I am trying to use "Clean Sum of Bests" on a splits file for a run that recently had a re-route. Whether or not I accept the suggested cleanups, the splits file is not correctly updated and I see "The lock count should never be negative" when going back from the edit screen to the main screen.

The splits file does show in the UI as edited but afaik nothing has actually changed and the cleanups are not reflected in the Sum of Bests displayed on my splits.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file, test, or entry point is named in the report. Reproduce the Clean Sum of Bests flow with a re-routed run, then trace the edit-screen transition and verify that the splits file and displayed Sum of Bests reflect the accepted cleanup without a negative lock count.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.