LiveSplit / LiveSplit/LiveSplit

Start Timer at Offset gets ignored for GameTime with AutoSplittingRuntime

Open
#2,628 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
1.9k
Forks
815
Avg merge
4d 17h
Merged PRs (30d)
3

Description

When using the `Start Timer at:` setting on LiveSplit to start at some non-zero time, and running an autosplitter through the `LiveSplit.AutoSplittingRuntime` component which does *not* call `set_game_time`, something in LiveSplit is setting the GameTime to 0.00 when starting the run, instead of leaving it at the non-zero `Start Timer at:` time.

This seems to be only a problem with LiveSplit or the LiveSplit.AutoSplittingRuntime component: LiveSplit One handles this just fine keeping the non-zero start time.

The autosplitter isn't calling `set_game_time`, and when I search the source code of `LiveSplit.AutoSplittingRuntime` I can't find any place where it calls `setGameTime` without the autospitter calling `set_game_time`, so I don't know what's causing this.

(the workaround that autosplitters can use, simply not calling `pause_game_time` or `resume_game_time` while the timer state is `NotRunning`, works well enough that I'd consider this to be low priority, and should not block a release)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with LiveSplit's “Start Timer at” setting at a non-zero time and an autosplitter using LiveSplit.AutoSplittingRuntime without set_game_time. Trace handling of set_game_time, pause_game_time, and resume_game_time while the timer is NotRunning; done means the configured non-zero start time is preserved when starting the run.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.