LiveSplit / LiveSplit/LiveSplit
Incorrect AtomicDateTime serialization when serializing Attempt struct to JSON
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 1.9k
- Forks
- 815
- Avg merge
- 4d 17h
- Merged PRs (30d)
- 3
Description
Came back to write some more unit tests and noticed the AtomicDateTime does not have a ToString() overload for when an Attempt struct is serialized to JSON, thus serializing to their type name. These methods might not be used right now and thus it might not have been caught still but are latent.
My intention was to only add tests and refrain from fixing code problems so that the PR can be accepted without too much thinking, so I'm documenting this problem to come back and fix it once I PR the tests.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating AtomicDateTime, the Attempt struct, and the unit tests mentioned in the issue. Reproduce Attempt JSON serialization and confirm that AtomicDateTime emits its intended value rather than its type name; done when the behavior is covered by a passing test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100