LinusU / LinusU/node-appdmg

Unable to create DMG using path with space in app name

Open
#238 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
158
PR merge metrics
No merged PRs in 30d

Description

Environment:
```
NPM: 10.8.1
APPDMG: 0.6.6
OS: macOS 13.5.2
```

My config.json is setup as the following:
```
{
"title": "My App",
"icon": "./icon.icns",
"background": "./bacground.png",
"icon-size" : 94,
"contents": [
{
"x": 408,
"y": 212,
"type": "link",
"path": "/Applications"
},
{
"x": 200,
"y": 212,
"type": "file",
"path": "My App.app"
}
]
}
```

These paths do not work,
`"path": "My App.app"`
`"path": "My\\ App.app"`

The console shows an error,
```
[15/21] Copying files... [FAIL]
Error: Command failed: cp -R .../My App.app
```

However, when creating a DMG with the same config without a space in the app file path,
`"path": "MyApp.app"`

This is able to successfully build a DMG.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure using the provided config.json and an app named “My App.app”. Start by tracing the code behind the “[15/21] Copying files...” step and compare it with the working “MyApp.app” case. Done means a DMG builds successfully when the app path contains a space.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system, desktop-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.