`temporaryImagePath` could disappear before disk is unmounted
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.7k
- Forks
- 158
- PR merge metrics
- No merged PRs in 30d
Description
`hdiutil detach` does two things: 1. it will unmount the volume from `/Volumes` and 2. it will detach the disk image. Currently, `appdmg` will retry calling `hdiutil detach` when it fails. However, if it fails due to 2, then `/Volumes/NAME` as specified in `temporaryImagePath` will be gone. Then subsequent retries will fail as well. We are observing this happening on a slow filesystem where the writes are being flushed but the volume was able to be unmounted.
Suggestion: Use `diskutil info /Volumes/NAME` to get the `Device Node` and use the node name for `hdiutil detach`.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the hdiutil detach retry logic and how temporaryImagePath is used. Check how diskutil info /Volumes/NAME exposes the Device Node, then verify that retries continue to target the node after the volume is unmounted; done means detach succeeds on the slow-filesystem scenario.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100