setting 'icon' to an existing iconfile results in 'TypeError'
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.7k
- Forks
- 158
- PR merge metrics
- No merged PRs in 30d
Description
on node `v10.17.0`:
```
TypeError: Cannot read property 'call' of undefined
at CpFileError.get (/somepath/node_modules/nested-error-stacks/index.js:22:52)
at /somepath/node_modules/gulp-util/lib/PluginError.js:45:35
at Array.forEach ()
at new PluginError (/somepath/node_modules/gulp-util/lib/PluginError.js:44:8)
at EventEmitter. (/somepath/node_modules/gulp-appdmg/index.js:20:26)
at EventEmitter.emit (events.js:198:13)
at EventEmitter.emit (domain.js:448:20)
at /somepath/node_modules/appdmg/lib/pipeline.js:102:10
at /somepath/node_modules/appdmg/lib/pipeline.js:29:9
at Pipeline.runRemainingCleanups (/somepath/node_modules/appdmg/lib/pipeline.js:74:45)
```
does not matter wether the file exists or not - only removing the property helps.
thanks for checking
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the failure with the `icon` property on Node v10.17.0, then trace the error through `gulp-appdmg/index.js`, `appdmg/lib/pipeline.js`, and `nested-error-stacks/index.js`. Done means setting `icon` no longer produces the reported TypeError, whether the referenced icon file exists or not.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100