Lightning-AI / Lightning-AI/pytorch-lightning
Change WandbLogger prefix separator to slash for better metric grouping
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 31.4k
- Forks
- 3.8k
- Avg merge
- 6d 7h
- Merged PRs (30d)
- 6
Description
### Description & Motivation
Wandb automatically groups metrics according to the prefix if the prefix is separated with `/`. This makes the user experience much better.
Change the default `WandbLogger.LOGGER_JOIN_CHAR = "/"` or allow users to give a separator at initialization.
### Pitch
_No response_
### Alternatives
_No response_
### Additional context
_No response_
cc @lantiga @morganmcg1 @borisdayma @scottire @parambharat
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the WandbLogger entry point and inspect LOGGER_JOIN_CHAR and the initialization path. Determine whether the default separator should become `/` or be configurable, then verify that logged metrics are grouped correctly and that the relevant logger tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, pytorch
- Domain
- machine-learning, observability
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100